nextcloud / nextcloud/spreed

Matterbridge binary version check yields error

Open
#13,137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: integration 📦
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Install Talk
  2. Install Matterbridge Plugin
  3. Check status on global Talk settings page
Expected behaviour

There should be no errors

Actual behaviour

The following error appears:


{"reqId":"VQ9lS0OWskdJVZxMxUxh","level":3,"time":"2024-08-25T23:49:19+00:00","remoteAddr":"2a09:bac2:2a78:1b4b::2b8:11","user":"normen","app":"PHP","method":"GET","url":"/settings/admin/talk","message":"Trying to access array offset on value of type bool at /var/www/html/custom_apps/spreed/lib/MatterbridgeManager.php#921","userAgent":"Mozilla/5.0 (iPad; CPU OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1","version":"29.0.5.1","data":{"app":"PHP"}}

Note that the version is still being shown correctly in the settings page.

Talk app

Talk app version: (see apps administration page: /index.php/settings/apps)
19.0.8

Custom Signaling server configured: yes/no and version (see Talk administration settings: /index.php/settings/admin/talk#signaling_server)
yes, b4dbbaadf210d5696db6018e59375ab543bac5b2~docker

Custom TURN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#turn_server)
yes

Custom STUN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#stun_server)
yes

Browser

Safari

Microphone available: yes

Camera available: yes

Operating system: Mac

Browser name: Safari

Browser version: Current

Browser log
``` --- ```

Server configuration

Operating system: Ubuntu 20

Web server: Apache+Nginx

Database: Maria

PHP version: 8.1

Nextcloud Version: 29.0.5

List of activated apps:

  - activity: 2.21.1
  - admin_audit: 1.19.0
  - assistant: 1.1.0
  - calendar: 4.7.16
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0
  - contacts: 6.0.0
  - cookbook: 0.11.1
  - cospend: 1.6.1
  - dav: 1.30.1
  - deck: 1.13.1
  - external: 5.4.0
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.1
  - files_accesscontrol: 1.19.1
  - files_downloadlimit: 2.0.0
  - files_external: 1.21.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - flow_notifications: 1.9.0
  - forms: 4.2.4
  - gpxpod: 5.0.18
  - groupfolders: 17.0.2
  - impersonate: 1.16.0
  - integration_openai: 2.0.3
  - integration_peertube: 1.0.4
  - integration_youtube: 0.3.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - mail: 3.7.7
  - news: 25.0.0-alpha8
  - nextcloud_announcements: 1.18.0
  - notes: 4.10.1
  - notifications: 2.17.0
  - oauth2: 1.17.0
  - oidc: 0.9.2
  - password_policy: 1.19.0
  - polls: 7.2.1
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - spreed: 19.0.8
  - talk_matterbridge: 1.26.0
  - tasks: 0.16.1
  - text: 3.10.1
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - updatenotification: 1.19.1
  - viewer: 2.3.0
  - workflowengine: 2.11.0

Nextcloud configuration:

-- really? --
Server log (data/nextcloud.log)
Insert your server log here

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at custom_apps/spreed/lib/MatterbridgeManager.php line 921 and reproduce the Matterbridge status check from the Talk administration settings page. Trace the binary version check result that produces the PHP warning, then verify that the warning is gone while the Matterbridge version remains displayed correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.