nextcloud / nextcloud/spreed

Cached proxy messages are wrongly "you-responsive" aka. flaky `features/federation/chat.feature:73`

Open
#12,957 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: api 🛠️ feature: chat 💬 feature: federation 🌐
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

features/federation/chat.feature:73 is flaky since some time:
grafik

Steps to reproduce

  1. As UserA on ServerA invite UserB1 from ServerB and UserB2 from ServerB to a chat
  2. As UserB1 post a message and delete it
  3. As UserB1 (BENNET from the screenshot) check left sidebar and chat for the delete message:
    grafik
  4. As UserB2 (NOT BENNET from the screenshot) check left sidebar and chat for the delete message:
    grafik
  5. If it looks correct, repeat with UserB2 as author and actor
Actual behaviour

At least for one of the UserB* there should be a wrong left sidebar message. The question is whether the message was federated for the first or second user quicker, or for the actor as a response for their action.

In the chat view it's all correct as we proxy the message request and can therefore correctly do the "you" analysis.
But in the cached PCM table we have only 1 message for all users. I guess we should use the non-you version for now, until we can fix this properly?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with features/federation/chat.feature:73 and reproduce the scenario using two invited users from the remote server, including swapping the message author. Compare the left-sidebar cached message with the chat view; done means the sidebar no longer shows an incorrect "you"-responsive message for either user.

Written by the indexing model from the issue text.

Assessment

Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.