"to" is duplicated when sending messages in "sendCallMessage"
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Setup external signaling.
- Start typing in chat.
- Look at messages being sent for the typing indication.
Expected behaviour
The session id the recipient should only be included once.
Actual behaviour
The session id of the recipient is used in the recipient and also included in the data:
https://github.com/nextcloud/spreed/blob/ff123623e76de5ba85fcd97898c07b305d5ca3ab/src/utils/signaling.js#L932-L941
It should not be part of data as the message will only be sent to the session in recipient and the recipient knows the own id.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/utils/signaling.js around lines 932-941 and reproduce the issue with external signaling by typing in chat while observing the typing-indication messages. Check how sendCallMessage assigns recipient and data; done means the recipient session id is included only in recipient, not duplicated in data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100