Limit to groups in federated target server breaks federation
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Admin of
nc2enables federation and sets the following settings:
user2is both in groupsadminandgeneral. user1@nc1invitesuser2@nc2into a federated conversation
Expected behaviour
Successful creation of a federated conversation. Limit to groups should limit the possibility to invite, not to be invited and in any case user2 is part of the groups allowed to use federation.
Removing all groups from "Limit to groups" prevents the issue.
Actual behaviour
Conversation is not created or invite fails.
nc2 logs:
Received a federation invite for user that is not allowed to use Talk Federation
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are identified. Reproduce the invite between nc1 and nc2 with a user in both an allowed and another group, then trace the federation authorization handling that produces the logged rejection. Done means an allowed user can be invited and the federated conversation is created while the group limit still restricts outgoing invitations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100