Encrypt appdata when using server side encryption with master key
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
With https://github.com/nextcloud/server/pull/2415 I disabled encryption for the appdata. Because if you are using user keys then you don't want to encrypt this data that is probably shared. However now that we have switched to the master key by default (right?) it makes sense to also encrypt the appdata folder if that is the case.
@schiessle assigning you since you know the encryption code best
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the encryption behavior changed by nextcloud/server#2415 and trace how the master-key and user-key modes handle the appdata folder. Determine where the master-key condition is decided, then verify that appdata is encrypted with a master key but remains unencrypted with user keys. Check the relevant encryption tests or add coverage for both modes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100