server.scss for login pages
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Hi,
Since NC 13 the "Renew Password" page for LDAP users doesn't load the server.scss anymore.
Talked with @juliushaertl who kindly helped to shed some light on this: As the guest template is also used by the maintenance/install page, it isn't sure whether database/caching is ready there, so the SCSSCacher from the server cannot be used, only plain CSS would do. Maybe in NC 14 it would be possible to add a separate template for other pages that are accessed in guest mode, like login pages and the foresaid "Renew Password" page.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading apps/user_ldap/templates/renewpassword.php and tracing how the guest template serves that page and the maintenance/install page. Check how server.scss is loaded for the Renew Password page and determine the appropriate template boundary without relying on the server SCSSCacher. Done means LDAP users' Renew Password pages load the intended styling while maintenance and install pages remain functional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, scss
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100