Proper user agent for Client Login flow
Open
Nobody has claimed this yet.
1. to develop
enhancement
feature: authentication
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
As noted in https://github.com/nextcloud/server/pull/7754 we have to send more detailed UserAgents when regsitering a new device using the client login flow.
Basically there are 4 tasks:
- Come up with a user agent string we need that contains all the info
- Send this string properly from the clients
- Android
- IOS
- Desktop
- Make sure we also parse it in https://github.com/nextcloud/server/blob/master/core/Controller/ClientFlowLoginController.php#L117 so we show a human readable string
- Make sure to parse it on the Secuirity (personal) page so we show it properly.
@ChristophWurst as discussed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked PR 7754 and core/Controller/ClientFlowLoginController.php around line 117, then locate the client-login handling and Security personal page code. Review how Android, iOS, and Desktop clients currently register devices and agree on the user-agent information to send and display. Done means all clients provide the agreed details and both server views render them readably.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, ios, php
- Domain
- authentication, backend, desktop-dev, mobile-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100