nextcloud / nextcloud/server

[Bug]: List of missing files does not always show correct file path

Open
#62,318 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 34-feedback bug
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

After a required manual upgrade of my NextCloud instance, I discovered that several files were reported as missing - probably due to an incomplete upload. While this was easy to fix, I noticed that not all missing files are reported with their exact location (path + filename) which made it more difficult than necessary to track down the missing files and re-upload them. Example report:

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- twofactor_totp
	- FILE_MISSING
		- js/twofactor_totp-main-login-setup.js.map.license
		- js/twofactor_totp-main-settings.js.map.license
- related_resources
	- FILE_MISSING
		- js/related_resources.js.map.license
		- js/vendors-node_modules_nextcloud_vue_dist_Components_NcRelatedResourcesPanel_js.related_resources.js.license
- dav
	- FILE_MISSING
		- lib/CalDAV/Search/Xml/Filter/CompFilter.php
- recommendations
	- FILE_MISSING
		- js/recommendations-dashboard.js.map.license
		- js/recommendations-main.js.map.license
		- js/recommendations-vendors-node_modules_rehype-highlight_index_js.js.map.license
- lookup_server_connector
	- FILE_MISSING
		- composer/composer.json
- files_pdfviewer
	- FILE_MISSING
		- js/files_pdfviewer-admin.js.map.license
		- js/files_pdfviewer-main.js.map.license
		- js/files_pdfviewer-node_modules_nextcloud_dialogs_dist_chunks_PublicAuthPrompt-7_GNN76e_mjs.js.map.license
		- js/files_pdfviewer-vendors-node_modules_mdi_js_mdi_js-node_modules_nextcloud_dialogs_dist_chunks_preview-BIbJGxX-8a4549.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_dist_chunks_ConflictPicker-CWBf0soh_mjs.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_dist_chunks_FilePicker-C1yRZfLt_mjs.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_dist_chunks__plugin-vue_export-helper-1tPrXgE0_mjs-nod-88e649.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_node_modules_nextcloud_vue_dist_components_NcColorPick-2135ac.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_node_modules_nextcloud_vue_dist_components_NcDateTimeP-55190c.js.map.license
		- js/files_pdfviewer-vendors-node_modules_nextcloud_dialogs_node_modules_nextcloud_vue_dist_components_NcTextField-759f92.js.map.license
		- js/files_pdfviewer-vendors-node_modules_rehype-highlight_index_js.js.map.license
		- js/files_pdfviewer-workersrc.js.map.license

For instance, the first entry should actually be reported as apps/twofactor_totp/js/main-login-setup.js.map.license - which is the file that's missing.

I noticed that some other files (not in the /apps/ directory) were reported with the correct path, but I propose to align this across all files to make it easier to fix.

Steps to reproduce
  1. Install NextCloud
  2. Delete some files in any of the apps/xyz/js directories
  3. Run the integrity scanner
  4. View the resulting report
Expected behavior

I would like the correct path to be shown in clear text.

Nextcloud Server version

34

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the integrity scanner and the code that formats its missing-file report; the issue provides a reproducible case by deleting files under an apps/xyz/js directory and running the scanner. Done means missing app files are displayed with their full apps/... path, while non-app paths remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.