nextcloud / nextcloud/server

Do not delete current folder when using delete hotkey in files and no files are selected

Open
#62,278 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage design enhancement feature: files
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

[!TIP]

Help move this idea forward
  • Use the 👍 reaction to show support for this feature.
  • Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
  • Subscribe to receive notifications about status changes and new comments.

Is your feature request related to a problem? Please describe.
When using the files app, the delete key will delete the current folder if you have no files selected. This caught me completely off guard and I almost deleted my whole documents folder without noticing. I'm lucky I caught it.

Related: using the delete key seems to not update the UI, unlike when using the options at the top of the UI.

Describe the solution you'd like
In my opinion, with no visibly selected file, the delete key should do nothing. This would match all other file explorers I've used on desktops.

Describe alternatives you've considered
If this is desired behavior for some admins/users, provide a customization option to remove this.

Additional context
Nextcloud version: Nextcloud Hub 26 Spring (34.0.1)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing delete-key handling in the Files app and compare it with the delete action exposed in the top UI. Confirm the behavior with no files selected, then make sure the hotkey performs no deletion in that state and verify that normal deletion still works when a file is selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.