nextcloud / nextcloud/server

[Bug]: Sharing files to public via emails should not be displayed in UI if it is turned off in settings

Open
#59,083 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 32-feedback bug feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

After the last update in v32 I've found that the files sharing UI contains the section 'External shares', explaining "Share files with others outside your organization via public links and email addresses. You can also share to {productName} accounts on other instances using their federated cloud ID."

At the same time in sharing settings the option "Allow users to share via link and emails" and Federation is off.

Steps to reproduce
  1. Go to File sapp. Click Details
  2. Go to section Share
  3. Observe External shares
Image
Expected behavior

This section should be hidden if "Allow users to share via link and emails" is off.

Nextcloud Server version

32

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 32.0.1 to 32.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Files app's Details > Share view and trace how the “External shares” section is displayed alongside the “Allow users to share via link and emails” and Federation settings. Done when the section is hidden whenever the relevant sharing options are disabled, while remaining available when they are enabled; verify the reproduction steps on Nextcloud Server 32.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.