nextcloud / nextcloud/server

[Bug]: Share with 'UserX' on remote server 'Y' message in federated share menu may show incorrect info.

Open
#59,068 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 32-feedback bug
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

When initiating a federated / remote share the following is shown on screen.
"Share with 'userX' on remote server 'Y'"

UserX shows the part of the federated cloud id before the first @ of the federated cloud id.
Y shows the part of the federated cloud id between the first @ and the second @ of the federated cloud id.

Would it not be better if:
UserX shows the part before the first @ + the part before the 2nd @, for instance the e-mail address or any other e-mail address like string that is used to identify users on the remote server.
Y shows the server address.

See below screenshot to see what happens if you share with:
before1stat@before2ndat@after2ndat.com
Where before1stat@before2ndat is the user specific id on the remote server and after2ndat.com is the remote server address.

Image

Since federated sharing is relatively complex it would help both the user and support if this message were to reflect the entered federated cloud id and correctly describe the remote server name.
When someone sends an error message screenshot it would be clearly visible which id was entered.

The remote server name may be reflected in all full remote user names (from start to 2nd @), but this may not always be the case.

Steps to reproduce
  1. External share
  2. Share with before1stat@before2ndat@after2ndat.com (not through e-mailing a public link).
  3. See info message
Expected behavior

Like above:

UserX shows the part before the first @ + the part before the 2nd @, for instance the e-mail address or any other e-mail address like string that is used to identify users on the remote server.
Y shows the server address.

Nextcloud Server version

32

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Reproduce the federated share flow with before1stat@before2ndat@after2ndat.com, then trace the share-menu message entry point. Done means the displayed user identity includes the intended user-specific portion and the server display uses the remote server address.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.