nextcloud / nextcloud/server

Admin Settings -> Basic Settings -> Email Server: User input should be trimmed to prevent frustration

Open
#59,055 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: settings
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

[!TIP]

Help move this idea forward
  • Use the 👍 reaction to show support for this feature.
  • Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
  • Subscribe to receive notifications about status changes and new comments.

Is your feature request related to a problem? Please describe.

When submitting settings and credentials for the mail server (under Admin Settings -> Basic Settings -> Email Server), the user input should be treated in a more forgiving way.
When copying and pasting infos from your email provider it's easy to include leading or trailing whitespace characters. Since the input fields are very narrow, it is hard to check for this error.
I have setup two Nextcloud instances so far and both times I was struggeling with this admittedly user error.

Describe the solution you'd like

The input should automatically be trimmed before validation.

Describe alternatives you've considered

Make the form fields wider so the user can see their entire input string at once without scrolling side to side.

Additional context

I am talking about this view:

Image There should be plenty of room to make the form fields wider or obvious user error like leading and trailing whitespace characters should be removed (maybe not for the password).

I love your project, keep up the good work!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Admin Settings > Basic Settings > Email Server and trace the form's validation for the mail-server fields. Check how leading and trailing whitespace is handled for each non-password input, then verify the behavior with the relevant existing tests or add coverage if none is present. Done means copied values with surrounding whitespace validate as expected without altering passwords.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
backend, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.