[Bug]: add name attributes with matching values to radio buttons to group them
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
Hi!
I just performed a small accessibility test and realized that the radio buttons "Default View" settings in the files app are not grouped with a name attribute.
Grouping them would increase keyboard accessibility, since you can jump between them with the arrow keys. The fix should be easy. Just add a for example name="default_view to both radio buttons.
Cheers,
Moritz
Steps to reproduce
- Open files app
- Open files settings
- Navigate with the keyboard to the "Default view" radio buttons
- Press arrow right / arrow left.
Expected behavior
The selected radio button should change when pressing the arrow keys.
Nextcloud Server version
32
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open apps/files/src/components/FilesAppSettings/FilesAppSettingsGeneral.vue around line 42 and inspect the two “Default view” radio buttons. Confirm their current keyboard behavior in the Files app settings, then add matching grouping attributes as described and verify that the arrow keys switch the selected option.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 70/100