nextcloud / nextcloud/server

[Bug]: add name attributes with matching values to radio buttons to group them

Open Beginner friendly
#58,729 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 32-feedback bug
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Hi!

I just performed a small accessibility test and realized that the radio buttons "Default View" settings in the files app are not grouped with a name attribute.

Grouping them would increase keyboard accessibility, since you can jump between them with the arrow keys. The fix should be easy. Just add a for example name="default_view to both radio buttons.

https://github.com/nextcloud/server/blob/master/apps/files/src/components/FilesAppSettings/FilesAppSettingsGeneral.vue#L42

Cheers,
Moritz

Steps to reproduce
  1. Open files app
  2. Open files settings
  3. Navigate with the keyboard to the "Default view" radio buttons
  4. Press arrow right / arrow left.
Expected behavior

The selected radio button should change when pressing the arrow keys.

Nextcloud Server version

32

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open apps/files/src/components/FilesAppSettings/FilesAppSettingsGeneral.vue around line 42 and inspect the two “Default view” radio buttons. Confirm their current keyboard behavior in the Files app settings, then add matching grouping attributes as described and verify that the arrow keys switch the selected option.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.