nextcloud / nextcloud/server

Make column width "size" and "modified" dependent on seperate css custom properties

Open Beginner friendly
#58,260 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 33-feedback bug
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Currently the widths of the columns "size" and "modified" depend on the value of the custom property --row-height and are calculated as calc(var(--row-height) * 2) and calc(var(--row-height) * 2.5) respectively. This seems to make sense with the english words "size" and "modified" but not so much for translations like "Grootte" and "Aangepast". The later get abbreviated to "Gro..." and "Aange..." even on screens wide enough to show the words completely resulting in suboptimal useability.

In FileListVirtual.vue add/modify:

.files-list {
...
	// adapt these depending on the ui language
	--col-width-size: 12ch;
	--col-width-mtime: 15ch;
...

	.files-list__row-size {
		width: var(--col-width-size);
		// Right align content/text
		justify-content: flex-end;
	}

	.files-list__row-mtime {
		width: var(--col-width-mtime);
	}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open FileListVirtual.vue and inspect the existing .files-list, .files-list__row-size, and .files-list__row-mtime styles. Replace the row-height-based widths with the specified custom properties and right-align the size content. Done means the size and modified columns use their independent widths and translated labels are not unnecessarily truncated.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.