nextcloud / nextcloud/server

Allow smaller subnets than /64 for security.ipv6_normalized_subnet_size

Open
#57,650 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

[!TIP]

Help move this idea forward
  • Use the 👍 reaction to show support for this feature.
  • Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
  • Subscribe to receive notifications about status changes and new comments.

Is your feature request related to a problem? Please describe.

If one operates a network for client devices with a single /64 IPv6 prefix and SLAAC, a single client using wrong passwords can impact all clients of the network. This cannot be mitigated at the moment, because security.ipv6_normalized_subnet_size will clamp values larger than 64 to 64.

Consider e.g. a wifi-network with a /64 IPv6 range and SLAAC. If one smartphone in that network has an outdated password stored in a calendar client, the entire /64 might be blocked, leading to delayed requests (due to throttling) for all other clients in that wifi network (and therefore bad user experience...).

Describe the solution you'd like

Allow values up to 128 for security.ipv6_normalized_subnet_size.

Describe alternatives you've considered

AFAICS the only viable solution might be turning off bruteforce protection - but it is a nice feature, therefore I would like to keep it enabled.

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and validation for the security.ipv6_normalized_subnet_size setting, then inspect related brute-force protection tests. The change is done when values through 128 are accepted and the normalized subnet behavior is covered by tests without disabling protection.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.