feat(Filesystem): Improve share providers logic
Open
Nobody has claimed this yet.
enhancement
feature: filesystem
feature: sharing
performance 🚀
php
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
The logic inside share providers could be improved.
- Use the
$mountProviderArgsinstead of joiningfilecache - Now that we join the direct user share, we don't need the group, talk room, deck board loop to check for membership?
- We can use the
$mountProviderArgs[*]->mountInfo->getMountPoint()instead of doing a LIKE${path}_% - Change the offset logic for a lastId one
- Allow providers to support multiple share types
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the share-provider code that uses $mountProviderArgs, filecache, mountInfo->getMountPoint(), membership checks, and lastId offsets. Read the existing provider and share-related tests before deciding which behavior is covered. Done means the listed provider and offset changes work without the current LIKE lookup or unnecessary membership loops, and providers can support multiple share types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100