`occ user:sync-account-data` without function
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
- Noticed while working on https://github.com/nextcloud/server/pull/57452
The command occ user:sync-account-data currently updates the displayname, when the backend implements IGetDisplayNameBackend:
But the account data that is used to compare the displayname, always return the up-to-date displayname:
(implemented at https://github.com/nextcloud/server/pull/39770)
So if I am not mistaken, occ user:sync-account-data is basically a NOP?
CC @juliusknorr as creator of the occ command.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read core/Command/User/SyncAccountDataCommand.php around lines 58-75 and lib/private/Accounts/AccountManager.php around lines 664-667, then reproduce the display-name comparison with occ user:sync-account-data. Confirm whether the command is a no-op and define completion as synchronizing account data correctly, with the behavior verified by appropriate coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100