[Bug]: Trashbin filename collision - data loss
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
If you have multiple files example.txt with the same name in different folders and delete them at the same time, only one is stored in the trashbin as example.txt.dTIMESTAMP_OF_DELETION, making it impossible to recover the other versions.
Steps to reproduce
- create path_a/example.txt and path_b/example.txt
- Delete both at the same time SOME_UNIX_TIME and have a bit of bad luck
- only one example.txt.dSOME_UNIX_TIME in your trashbin
Expected behavior
see two different files, maybe with some hash of the path as part of the extension or at least ms timestamp resolution to reduce likelihood of collision
Nextcloud Server version
31
Operating system
None
PHP engine version
PHP 8.3
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the collision with two files named example.txt in separate folders deleted at the same time, then trace the server's trashbin filename handling. Confirm the fix by verifying that both deleted files appear separately and can each be recovered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100