nextcloud / nextcloud/server

[Bug]: Trashbin filename collision - data loss

Open
#57,447 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 31-feedback bug feature: trashbin hotspot: filename handling
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

If you have multiple files example.txt with the same name in different folders and delete them at the same time, only one is stored in the trashbin as example.txt.dTIMESTAMP_OF_DELETION, making it impossible to recover the other versions.

Steps to reproduce
  1. create path_a/example.txt and path_b/example.txt
  2. Delete both at the same time SOME_UNIX_TIME and have a bit of bad luck
  3. only one example.txt.dSOME_UNIX_TIME in your trashbin
Expected behavior

see two different files, maybe with some hash of the path as part of the extension or at least ms timestamp resolution to reduce likelihood of collision

Nextcloud Server version

31

Operating system

None

PHP engine version

PHP 8.3

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the collision with two files named example.txt in separate folders deleted at the same time, then trace the server's trashbin filename handling. Confirm the fix by verifying that both deleted files appear separately and can each be recovered.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.