nextcloud / nextcloud/server

don't setup the complete provider in Root::getByIdInPath

Open
#57,391 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop performance 🚀
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Root::getByIdInPath uses SetupManager::setupForProvider to get the mounts for the file (as opposed to a full setup), with the new IPartialMountProvider it should be possible to further optimize this to only fetch the actual mounts we need, since the logic has already figured out the mountpoints it cares about.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Root::getByIdInPath and trace its use of SetupManager::setupForProvider, then read the IPartialMountProvider interface mentioned in the issue. The work is complete when this path fetches only the mounts it needs instead of setting up the complete provider.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.