Don't do a full nested mount setup when listing a directory.
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Currently, listing a directory, performs a filesystem setup for the directory and all of it's children, even though we don't really care about deeply nested mounts (see also https://github.com/nextcloud/server/issues/57350)
There are 2 ways we could optimize this.
- Add an option to setup the filesystem for only 1 level of child-mounts instead of child-mounts at any depth.
- Instead of setting up the actual mount points for the children, just fetch the metadata for the mountpoints (using
oc_mounts) and then createLazyFolderstubs with them.
Option 2. should be the more optimal one, but it would require storing per-users permissions (or permissions mask) in oc_mounts to deal with the fact that different users have different permissions for shares/groupfolders.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the directory-listing filesystem setup and how child mounts are represented in oc_mounts and LazyFolder. Compare the two optimization options described in the issue, including their implications for per-user permissions. The issue does not define a chosen approach or concrete completion criteria, so those need to be clarified before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, databases, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100