nextcloud / nextcloud/server

[Bug]: Error in Activity when user shares nested folder with third user which is owned by admin

Open
#56,133 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 32-feedback bug feature: activity and notification feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Activity reporting has a bug in notification when user shares a folder/file with another user while the shared folder/file is nested and the parent folder is shared with the share initiator.

Steps to reproduce
  1. Admin creates folder and subfolder
  2. Admin shares the parent folder with Will Smith - Will Smith has access to parent and subfolders/files
  3. Will Smith in turn then shares a file or subfolder with Ben.
  4. Admin receives an email notification / activity on the dashboard that the Parent folder was shared with Ben. In fact only the subfolder/file was shared with Ben and Ben doesn't have access to parent folder.
Image Image
Expected behavior

The activity / email notification about the activity should say which specific folder in a parent folder was shared with another user, not the parent folder.

Nextcloud Server version

32

Operating system

Debian/Ubuntu

PHP engine version

Other

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report
{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "skeletondirectory": "",
        "maintenance_window_start": 1,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpsecure": "ssl",
        "mail_smtpauth": true,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "filelocking.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "timeout": 0,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "fqdn.io",
            "xxx.xxx.xxx.xxx`",
            "100.124.8.14"
        ],
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED",
            "HTTP_X_FORWARDED_FOR",
            "HTTP_CF_CONNECTING_IP"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "32.0.1.2",
        "overwrite.cli.url": "https:\/\/nc.nomadist.io",
        "overwriteprotocol": "https",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "optional",
        "twofactor_enforced": "true",
        "default_language": "en_US",
        "default_locale": "en_US",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": [
            "Unsecured"
        ],
        "loglevel": 2,
        "maintenance": false,
        "app_install_overwrite": {
            "0": "richdocumentscode",
            "1": "webhooks",
            "2": "libresign",
            "4": "bookmarks_fulltextsearch",
            "8": "groupfolders",
            "9": "files_rightclick"
        },
        "data-fingerprint": "b4603c3cfb8360bea5d5371761e9a81f",
        "theme": "",
        "defaultapp": "files"
    }
}
List of activated Apps
Enabled:
  - activity: 5.0.0-dev.0
  - admin_audit: 1.22.0
  - bruteforcesettings: 5.0.0-dev.0
  - cloud_federation_api: 1.16.0
  - comments: 1.22.0
  - dashboard: 7.12.0
  - dav: 1.34.2
  - drawio: 3.1.2
  - federatedfilesharing: 1.22.0
  - files: 2.4.0
  - files_accesscontrol: 3.0.1
  - files_downloadlimit: 5.0.0-dev.0
  - files_pdfviewer: 5.0.0-dev.0
  - files_reminders: 1.5.0
  - files_sharing: 1.24.0
  - files_trashbin: 1.22.0
  - files_versions: 1.25.0
  - groupfolders: 20.1.2
  - integration_documenso: 1.1.1
  - logreader: 5.0.0-dev.0
  - lookup_server_connector: 1.20.0
  - notifications: 5.0.0-dev.0
  - oauth2: 1.20.0
  - onlyoffice: 9.11.0
  - password_policy: 4.0.0-dev.0
  - privacy: 4.0.0-dev.0
  - profile: 1.1.0
  - provisioning_api: 1.22.0
  - related_resources: 3.0.0-dev.0
  - serverinfo: 4.0.0-dev.0
  - settings: 1.15.1
  - sharebymail: 1.22.0
  - sharelisting: 1.3.0
  - suspicious_login: 10.0.0-dev.0
  - systemtags: 1.22.0
  - text: 6.0.1
  - theming: 2.7.0
  - twofactor_backupcodes: 1.21.0
  - twofactor_nextcloud_notification: 6.0.0-dev.0
  - twofactor_totp: 14.0.0
  - updatenotification: 1.22.0
  - user_status: 1.12.0
  - viewer: 5.0.0-dev.0
  - webhook_listeners: 1.3.0
  - webhooks: 0.4.3
  - whiteboard: 1.4.0
  - workflowengine: 2.14.0
Disabled:
  - app_api: 32.0.0 (installed 5.0.2)
  - circles: 32.0.0 (installed 25.0.0)
  - contactsinteraction: 1.13.1 (installed 1.12.0)
  - encryption: 2.20.0 (installed 2.19.0)
  - federation: 1.22.0 (installed 1.21.0)
  - files_external: 1.24.0 (installed 1.17.0)
  - files_rightclick: 0.15.1 (installed 0.15.1)
  - firstrunwizard: 5.0.0-dev.0 (installed 4.0.0)
  - integration_openai: 3.7.1 (installed 3.7.1)
  - nextcloud_announcements: 4.0.0-dev.0 (installed 1.14.0)
  - photos: 5.0.0-dev.1 (installed 4.0.0-dev.1)
  - recommendations: 5.0.0-dev.0 (installed 4.0.0)
  - side_menu: 5.1.3 (installed 5.1.3)
  - spreed: 22.0.2 (installed 22.0.2)
  - support: 4.0.0-dev.0 (installed 3.0.0)
  - survey_client: 4.0.0-dev.0 (installed 3.0.0)
  - unroundedcorners: 1.1.5 (installed 1.1.5)
  - user_ldap: 1.23.0
  - weather_status: 1.12.0 (installed 1.11.0)
Nextcloud Signing status
No error have been found
Nextcloud Logs

Additional info

Installed Nextcloud using Docker Compose, not AIO.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the listed reproduction steps and the Activity and files_sharing apps involved in the nested-share flow. Compare the activity and email notification with the specific file or subfolder shared, and consider the issue done when both identify that nested item rather than the parent folder.

Written by the indexing model from the issue text.

Assessment

Tech stack
mariadb, php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.