Plural missing on CalDAV Activity when creating multiple Calendar events
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Steps to reproduce
- Create multiple events around the same time on Nextcloud Calendar
- Look at your Activities
- An activity stating "You created event Event 1, Event 2..."
Expected behaviour
If multiple events are created, activity should read as "You created events Event 1, Event 2..."
Actual behaviour
The word "event" is not plural.
Server configuration
Nextcloud 12
Operating system: N/A
Web server: N/A
Database: N/A
PHP version: N/A
Nextcloud version: 12
Updated from an older Nextcloud/ownCloud or fresh install: N/A
Where did you install Nextcloud from: git source
Client configuration
Browser: Noticed on Nextcloud-dev Android client, but client agnostic
Relevant code seems to be here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/Activity/Provider/Event.php#L89
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open apps/dav/lib/CalDAV/Activity/Provider/Event.php around line 89 and reproduce the activity generated after creating one event and multiple events. Update the activity wording so multiple events use the plural form while singular events retain the singular form, then verify both cases in Activities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100