nextcloud / nextcloud/server

Change domain URL in shared links

Open
#54,904 2 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
In my usage scenario, NextCloud has two access methods: private and public, so I need to customize the domain name section in the shared link to point to a domain name for offloading, and jump to the private domain name when the intranet link is available, and vice direction to the public domain name.

The offload part has nothing to do with nextcloud, I have implemented the relevant functions. Now, I need to change the shared link to the domain name I want to use for triage, but I haven't found a workaround.

I found the overwrite.cli.url parameter, but this parameter seems to have a big limitation, it doesn't work in a container environment and reading the description, I think this parameter is only used during development and debugging.

I need a parameter to customize the domain name I share the link with. I can try to make modifications, here are two ideas for modifications.

Describe the solution you'd like
I can try to make modifications, here are two ideas for modifications.

  1. Expand the application of overwrite.cli.url to all startup methods.
  2. Add new parameters for control.

The main modification location is: https://github.com/nextcloud/server/blob/master/lib/private/URLGenerator.php#L261

Additional context
https://github.com/nextcloud/server/issues/27240

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/private/URLGenerator.php around line 261 and review how overwrite.cli.url is currently applied. Compare the requested private and public shared-link behavior with the context in issue #27240. Done means a defined configuration can make shared links use the intended domain, including the reported container startup scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.