nextcloud / nextcloud/server

Fix sharding on oc_files_metadata in getMetadataFromFileIds and properly test it

Open
#54,633 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🌍 scaling 1. to develop enhancement
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

came up in https://github.com/nextcloud/server/pull/54277 when trying to do a select * from oc_files_metadata where file_id in [ ...... ]

As the oc_files_metadata will continue growing, it likely makes sense to do that

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating getMetadataFromFileIds and reviewing the context from pull request 54277, including the query against oc_files_metadata. Determine the intended sharding behavior and add coverage that exercises it; done means the metadata lookup works for sharded data and is properly tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, sql
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.