nextcloud / nextcloud/server

Dubious usefulness of text filter chip

Open
#54,433 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

design feature: search
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Image

This thing that shows up when searching files is weird. For the other filter methods, they make sense. But for search, it mostly seems like duplicate information, takes up space, doesn't look great, and generally: is not a standard pattern.

I wonder if we need it at all?

Is it there for some reason that I don't know? Eg. filtering by text using a method other than search? In that case, I feel like it should only show up if that is invoked. If not, I think it should just be removed. We don't do this anywhere else afaik and I don't think anyone complained.

cc @nextcloud/designers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue points to the file-search UI and its text filter chip, but names no file or test. Start by tracing the search and filter entry points that render the chip, then confirm with the design team whether it is needed for non-search text filtering. Done means the behavior is agreed and the chip follows that decision without disrupting the other filter methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
design, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.