nextcloud / nextcloud/server

Versions on Local External Storage are only visible for the User who modified the File

Open
#54,246 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 31-feedback enhancement
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Context: editing a file on an external storage of type local

While the current version is visible to anyone with access to the respective folder, the visible versions are only the ones created by the current user, not those of other users. Consequently, each user's folder on the server disk contains a respective file_versions directory).

For a collaboration system, expected would be that everybody sees all versions, regardless by whom they were created.

Steps to reproduce

With versioning enabled:

  1. Log in as user A.
  2. Create a file in a folder located on an external storage of type local.
  3. Edit the file to create a new version.
  4. Log in as user B.
  5. The version of user A is not visible.
  6. Edit the file twice to create new versions.
  7. As User A, the intermediate version is not visible, only the latest state.
Expected behavior

Every user should have access to all versions, regardless of who created them.

Nextcloud Server version

31

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report
{
    "system": {
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "ara.michael-thomas.net"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/ara.michael-thomas.net",
        "dbtype": "mysql",
        "version": "31.0.7.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "installed": true,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "loglevel": 1,
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "PLAIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "maintenance": false,
        "maintenance_window_start": 1,
        "trashbin_retention_obligation": "auto,30",
        "theme": "",
        "mysql.utf8mb4": true,
        "app_install_overwrite": [
            "bruteforcesettings"
        ]
    }
}
List of activated Apps
Enabled:
  - activity: 4.0.0
  - app_api: 5.0.2
  - audioplayer: 3.4.1
  - bookmarks: 15.1.1
  - bruteforcesettings: 4.0.0
  - cloud_federation_api: 1.14.0
  - dav: 1.33.0
  - duplicatefinder: 1.7.3
  - federatedfilesharing: 1.21.0
  - federation: 1.21.0
  - files: 2.3.1
  - files_downloadlimit: 4.0.0
  - files_external: 1.23.0
  - files_pdfviewer: 4.0.0
  - files_sharing: 1.23.1
  - files_trashbin: 1.21.0
  - files_versions: 1.24.0
  - firstrunwizard: 4.0.0
  - groupfolders: 19.1.2
  - logreader: 4.0.0
  - lookup_server_connector: 1.19.0
  - oauth2: 1.19.1
  - privacy: 3.0.0
  - profile: 1.0.0
  - provisioning_api: 1.21.0
  - recommendations: 4.0.0
  - related_resources: 2.0.0
  - serverinfo: 3.0.0
  - settings: 1.14.0
  - sharebymail: 1.21.0
  - systemtags: 1.21.1
  - text: 5.0.0
  - theming: 2.6.1
  - twofactor_backupcodes: 1.20.0
  - updatenotification: 1.21.0
  - user_ldap: 1.22.0
  - viewer: 4.0.0
  - webhook_listeners: 1.2.0
  - workflowengine: 2.13.0
Disabled:
  - admin_audit: 1.21.0
  - circles: 31.0.0 (installed 25.0.0)
  - comments: 1.21.0 (installed 1.2.0)
  - contactsinteraction: 1.12.0 (installed 1.10.0)
  - dashboard: 7.11.0 (installed 7.1.0)
  - encryption: 2.19.0
  - files_reminders: 1.4.0 (installed 1.2.0)
  - nextcloud_announcements: 3.0.0 (installed 1.18.0)
  - notifications: 4.0.0 (installed 2.0.0)
  - password_policy: 3.0.0 (installed 1.2.2)
  - photos: 4.0.0 (installed 2.5.0)
  - support: 3.0.0 (installed 1.4.0)
  - survey_client: 3.0.0 (installed 1.3.0)
  - suspicious_login: 9.0.1
  - twofactor_nextcloud_notification: 5.0.0
  - twofactor_totp: 13.0.0-dev.0
  - user_status: 1.11.0 (installed 1.1.1)
  - weather_status: 1.11.0 (installed 1.1.0)
Nextcloud Signing status
No errors have been found.
Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the files_versions and files_external apps, focusing on how versions for local external storage are associated with users. Reproduce the two-user scenario described in the issue, then trace version listing and creation; done means every user with folder access can see all versions, including intermediate versions created by others.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.