nextcloud / nextcloud/server

enh: Unifiy always ask for password and enforce password checkboxes

Open
#54,245 2 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

In sharing settings of the admin section

  • Enable Always ask for a password or Set default expiration date for shares via link or mail
  • Then enable password or date ENFORCE
  • Disable the initial Always ask for a password or Set default expiration date for shares via link or mail checkbox

The ENFORCE setting is still set to true in the DB. Despite the parent checkbox being disabled
That means we need to check for both checkboxes to really ensure the date or password is enforced

See : https://github.com/nextcloud/server/pull/54159

The ENFORCE setting is still set to true in the DB. Despite the parent checkbox being disabled
That means we need to check for both checkboxes to really ensure the date or password is enforced

These new checks solve it on the client side but where are the checks to remove the db from the inconsistent state?

You need add a change that unchecks the sub checkbox when the main is unchecked making sure both requests are sent to the db? (This would fix the original but and the existing fix with be a guardrail)

Originally posted by @nfebe in https://github.com/nextcloud/server/pull/54159#pullrequestreview-3085033747

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.