nextcloud / nextcloud/server

Add confirmation for removing a trusted server

Open
#53,765 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 32-feedback enhancement feature: federation low
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

It's really easy to accidentally remove a trusted server especially that the consequences of that mistake can be costly.

Steps to reproduce
  1. Go to sharing admin settings
  2. scroll to trusted servers
  3. click on the delete icon of one of the servers
  4. voilà
Expected behavior

There should be a type of confirmation where you should even be prompted to put in your password.
Also when adding, as it sends GDPR user info to others.

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin in the sharing admin settings and trace the trusted-server add and delete actions from the UI. Define the confirmation and password-prompt behavior for removal, and determine whether adding a server also needs confirmation; the work is done when these actions prevent accidental changes and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
backend, frontend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.