nextcloud / nextcloud/server

Add setup check for Cloudflare proxy usage detection

Open
#53,526 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: settings
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Benefits:

  • Inform admins that they may have upload problems (not working and/or poorer performance) due to chunk sizing and timeouts
  • Inform admins that they may experience problems that will not be supported (if RocketLoaderr is enabled) such as login issues and unexplained application problems

Proposed checks:

  • INFO when detected[^1].
    • transaction size limits (i.e. upload chunk size limited to 100MB)
    • transaction time limits (impacts chunk assembly)
    • always remember to pause/disable when troubleshooting front-end issues
  • ERROR when Rocket Loader is detected[^2]
    • must be disabled with Nextcloud
    • breaks things (logins, calendar, etc)

[^1]: We can detect the usage of Cloudflare [reverse] proxy mode by the presence of the cf-ray HTTP header
[^2]: When CF is detected to be in-use, we can check for the presence of rocket-loader.min.js added /login via <script> and/or check for ajax.cloudflare.com being added (by CF) to Content-Security-Policy

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the setup-check flow and the /login response, using the cf-ray header, rocket-loader.min.js, and Cloudflare additions to Content-Security-Policy as the detection points. Done means administrators receive an INFO warning for detected Cloudflare proxy limits and an ERROR when Rocket Loader is detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.