nextcloud / nextcloud/server

Parameterize the minimum number of selected files required to enable the delete confirmation popup.

Open
#53,448 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement low
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

In its current state, the server asks for confirmation to remove files only if at least 5 files have been selected, when the recycle bin is enabled.

I think it would be useful to have that limit as a configurable parameter in config.php, so that it can be set as desired, specifically to 1 to always force the request popup.

See https://github.com/nextcloud/server/blob/master/apps/files/src/actions/deleteAction.ts#L87

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at apps/files/src/actions/deleteAction.ts around the linked selection threshold, then trace how configuration values are exposed through config.php. Make the minimum selected-file count configurable and verify that setting it to 1 always triggers the delete confirmation popup.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, typescript
Domain
full-stack
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.