nextcloud / nextcloud/server

Factor out custom property mapping/serializing/deserializing logic from `CustomPropertiesBackend` to make it reusable

Open
#52,702 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

♻️ refactor 1. to develop feature: dav technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

Sometimes, a piece of code needs to access a custom property of a calendar. Currently, this is only possible when this piece of code has access to a SabreDAV Server instance. We should allow Nextcloud code to short-circuit this and access the properties directly.

Reimplementing the mapping and deserialization logic leads to duplicated and unmaintainable code.

Example: #51081

Describe the solution you'd like
It would be nice to move the property mapping and fetching logic to another class which doesn't depend on a Server instance. This could be the PropertiyMapper for example.

Describe alternatives you've considered
None

Additional context
None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate CustomPropertiesBackend and review how it currently maps, fetches, serializes, and deserializes calendar custom properties through the SabreDAV Server instance. Compare the duplication described in example #51081 and assess the proposed PropertiyMapper direction. Done means the logic is reusable without a Server instance and existing behavior remains covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.