Is class ng-csp still needed?
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
It was added 12 years ago for angular js: https://github.com/owncloud/core/pull/1902
https://github.com/nextcloud/server/blob/648745d5248a7b6b97049fa8f034c442e77eb99d/core/templates/layout.base.php#L9
https://github.com/nextcloud/server/blob/648745d5248a7b6b97049fa8f034c442e77eb99d/core/templates/layout.guest.php#L9
https://github.com/nextcloud/server/blob/648745d5248a7b6b97049fa8f034c442e77eb99d/core/templates/layout.public.php#L8
https://github.com/nextcloud/server/blob/648745d5248a7b6b97049fa8f034c442e77eb99d/core/templates/layout.user.php#L22
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the historical AngularJS context and the referenced lines in core/templates/layout.base.php, layout.guest.php, layout.public.php, and layout.user.php. Determine whether ng-csp is still required in these templates; done means reaching a supported decision about retaining or removing the class and verifying all four layouts consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angularjs, php
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100