[Bug]: User status heartbeat should not schedule a new request, before the old is finished
Open
Nobody has claimed this yet.
0. Needs triage
31-feedback
bug
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
- Have a non-responding server
- Open the network tab on dev tools
- See that there multiple PUT requests for
/ocs/v2.php/apps/user_status/api/v1/heartbeat?format=jsonin pending state.
Expected behavior
Only schedule heartbeats when the previous ones finished
Nextcloud Server version
31
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the client-side implementation of the /ocs/v2.php/apps/user_status/api/v1/heartbeat?format=json request and reproduce the issue with a non-responding server while watching pending requests in the network tab. Done means a new heartbeat is not scheduled while the previous PUT remains unfinished, and the existing heartbeat behavior still works after a response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- api, backend, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100