Translate humanFileSize in other languages
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
The filesize unit in humanFileSize is not translated. Other languages use other abbreviations than KB or GB.
Describe the solution you'd like
Adding these strings to the translation system.
Describe alternatives you've considered
Leaving it as is
Additional context
Please bear in mind that in some situations the reverse is done later, 2GB is turned back into a number of bytes.
So, a deeper analysis is needed, to look into usage of the method and whether it would be acceptable to add translation to it, or whether it's needed to add a second method or a parameter for a localized version.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the humanFileSize method and the translation system, then inspect every usage of the method to identify places where its output is later converted back into bytes. Done means determining whether localized units are safe throughout those usages and documenting or implementing the appropriate translation approach, including any needed separate method or parameter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- localization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100