nextcloud / nextcloud/server

[Bug]: Previews and Download not available for Link Shares of Remote Shares

Open
#51,569 9 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 29-feedback 30-feedback bug feature: federation feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Bug description

While testing the backports for https://github.com/nextcloud/server/pull/51389, I noticed that although link shares can be opened, previews are not displayed, and the download button is missing. This behavior seems unusual, but I'm not familiar with the topic, so it might be the expected outcome. 🤷

Steps to Reproduce:
  1. Set up Alice on Instance A and Bob on Instance B.
  2. Alice uploads a folder containing pizza pictures to Instance A.
  3. Alice shares the pizza folder with Bob on Instance B, granting "View only" or "Can edit" permissions.
  4. Bob can open the share, view the pizza pictures, and sees the download option.
  5. Bob creates a public link share for the folder.
  6. When opening the link, the list of images is displayed, but previews are not shown, and it's not possible to open or download the images.

Additionally, I observed that the "hide download" option for the link share is enabled and cannot be unchecked because checkInheritedAttributes overwrites it. Reverting https://github.com/nextcloud/server/pull/50642 did not help.

Instance A (share initiator)

Image

Instance B (share receiver)

Image

Instance B (public link share)

Image

Expected behavior:

I'm unsure 🙈

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Instance A/Instance B federated-share flow and the public link share using the pizza-picture steps. Start by tracing the mentioned checkInheritedAttributes behavior and compare the link-share permissions with the working remote share; clarify the expected preview and download behavior before treating consistent access in the public link as done.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.