nextcloud / nextcloud/server

[Bug]: Using a download manager on public shares can trigger thousands of push-notifications / trigger fair use limit

Open
#50,993 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 30-feedback bug feature: activity and notification feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Using a download manager to download files from a shared link on a poor network connection can cause thousands of push-notifications triggering the fair use push limit ("the gateway limits the number of push notifications per server and the limit was reached for this server.").

It seems as if every connection / resume of a download triggeres the "File was [successfully] downloaded" notification.

Steps to reproduce
  1. Enable push notifications for public shared directories / files.
  2. Upload some large files to a directory (in this case on an external smb-storage, 55GiB and 15GiB)
  3. Share that directory via a public link (read-only + download allowed). Open the public share. Access the "Download"-Button for a file in that directory via the three-dot-menu. Pass the generated actual download URL (https://<nc>/s/<share>/download?path=%2F&files=video.mp4&downloadStartSecret=<secret>) to a download manager that is capable to resume a download.
  4. To reproduce:
    • a) Be on a poor, instable network connection that makes it neccessary for the download manager to reconnect/resume regularly (or interrupt it by pressing pause & resume)
    • b) use a download manager that uses multiple parallell connections to get the file, e.g.: axel -a -n 4 "https://<nc>/s/<share>/download?path=%2F&files=video.mp4&downloadStartSecret=<secret>")

a) The "File was downloaded via public share" push notification triggered for every resume.
b) The "File was downloaded via public share" push ntificatin is triggered for every parallell connection (plus x), e.g. the example above with axel causes instantly 5 push notifications.

Image

Expected behavior

There should be exactly one Push-Notification for one download. Or maybe two (Download started via public link, Download finished via public link). If a client resumes the download there should be no additional push notifications.

The NC Push Gateway should restore the fair-use state automatically after some time.

Nextcloud Server version

30

Operating system

RHEL/CentOS

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report
{
    "system": {
        "log_type": "file",
        "logfile": "\/var\/log\/nextcloud.log",
        "loglevel": 0,
        "logdateformat": "F d, Y H:i:s",
        "syslog_tag": "Nextcloud",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "overwritehost": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "30.0.6.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "skeletondirectory": "",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "logtimezone": "Europe\/Berlin",
        [snapp]
        "simpleSignUpLink.shown": false,
        "updater.release.channel": "stable",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "timeout": 0
        },
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "trashbin_retention_obligation": "auto, 5",
        "app_install_overwrite": [
            "user_backend_sql_raw"
        ],
        "deferred_script_loading": true,
        "memories.db.triggers.fcu": true,
        "memories.exiftool_no_local": true,
        "memories.vod.path": "\/var\/www\/nextcloud\/apps\/memories\/bin-ext\/go-vod-amd64",
        "defaultapp": "dashboard",
        "files.chunked_upload.max_size": 104857600
    }
}
List of activated Apps

Nextcloud Signing status
No errors have been found.
Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named in the report. Start by tracing the public-share download URL and the push notification emitted when a download resumes or uses parallel connections. Done means a single notification per download rather than one per connection or resume, with the fair-use state behavior clarified and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.