nextcloud / nextcloud/server

Incoming PHP-FPM changes for httpd ProxyPass and ProxyPassMatch handling.

Open
#50,738 9 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Apology for opening this nextcloud possible non issue but wanted to double check with you some changes that I'm adding to php-fpm in terms of handling PATH_INFO from ProxyPass and ProxyPassMatch which is quite inconsistent. The issue with those is that they send URL encoded path info and script file name. I applied the PATH_INFO fix in https://github.com/php/php-src/issues/17643 which just got merged and should be part of 8.3.18. It will basically provide the PATH_INFO decode. This should be quite safe but wanted to check with you in case you do some special handling for that. Another one which would decode the whole script path will be probably just for master: https://github.com/php/php-src/issues/17645 . But if you can see any issue with that, I could maybe add some switch for it.

This is mainly created here because there were some issues reported here. This in relation to past bugs https://github.com/nextcloud/server/issues/37852 and https://github.com/nextcloud/server/issues/40943 create by @mrAceT .

Feel free to close this it if you don't see any potential issues for nextcloud after this gets implemented.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading php-src issues 17643 and 17645, then review the related Nextcloud issues 37852 and 40943. Trace how Nextcloud handles PATH_INFO from PHP-FPM behind Apache ProxyPass and ProxyPassMatch; no specific file or test is named, so completion would be a confirmed compatibility assessment and identification of any required Nextcloud change.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.