nextcloud / nextcloud/server

[Bug]: Calendar event changed notification diff: a previously empty value is not visible

Open
#50,712 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop 31-feedback bug feature: caldav feature: dav
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

I a notification about a changed calendar event, overwritten values are supposed to be shown with a strike-through text-decoration. If the previous value is empty, e.g. because no location was set, then the previous value is empty, and thus not shown at all. Then there's no way to determine from the email was has actually changed.

The HTML part of the email contains <span style='text-decoration: line-through'></span>.

The text-part does not contain any hint on the previous value.

This is on cloud.nc.c from today (2025-02-07).

Steps to reproduce
  1. Create an event with another participant, leave the location field empty.
  2. Edit the event to contain some text in the location field.
  3. Read the notification email of the additional partitipant.
Expected behavior

I would expect that the notification explains to me, what has changed. If a field was previously empty, it must somehow be highlighted as new (also in the text-part, please!).

I would also find it helpful if there was a summary, which fields did change, so I don't have to scan all fields for (maybe tiny) text changes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the calendar event change notification email generation and compare how the HTML and text parts represent an empty previous value. Reproduce the location change described in the issue; done means an empty-to-value change is clearly conveyed in both parts of the notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.