Some share recipient type icons missing
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
In the screenshots below, I show you that in some cases icons are displayed, and in other cases there are no icons. I don't know if I've covered all the scenarios, but, in my opinion, ALL sharing suggestions should have icons, to make the UX as understandable, pleasant and polished as possible.
Internal shares with user : no single user icon in front of suggested user(s)
Federated share : no federated share representative icon in front of suggested federated user (or group), while there is an icon in front of external e-mail share suggestion
Internal shares with groups have icons
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Reproduce the sharing-suggestion scenarios shown in the issue, then trace the recipient type rendering in the sharing UI. Done means internal users, federated users or groups, and external email suggestions all display an appropriate representative icon.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100