nextcloud / nextcloud/server

[Enh] : Complete design requirements for sharing sidebar split

Open
#50,375 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

♻️ refactor 1. to develop enhancement feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Left over on non-blocking reviews from : https://github.com/nextcloud/server/pull/50282

pending from original design requirements:

  • Limit list length to 3 shares and "show all" (to show all shares)

from @marcoambrosini

  • Copy internal link should go into the multi-select as an always visible option
  • Share link component should show a button if no links are present as per the mockup, but below the input field

from @nfebe

  • Backend API should not handle detection of share type? (for example with mail share, in sharinginput)
  • "Search for share recipients" looks off should probably "visually hide for accessibility"

  • Confirm/check whether the deprecated projects feature (#28320) can be dropped?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.