nextcloud / nextcloud/server

[Bug(CardDav)]: Wrong sync-token returned when limit is set

Open
#50,086 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 31-feedback bug feature: carddav
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

This is a potential bug to be investigated further:

  1. When syncing the sync token is set to the latest sync-token of the address book
    https://github.com/nextcloud/server/blob/master/apps/dav/lib/CardDAV/CardDavBackend.php#L856-L863

  2. But if a limit is applied -> https://github.com/nextcloud/server/blob/master/apps/dav/lib/CardDAV/CardDavBackend.php#L889-L891
    The sync token is not updated to the correct value where the latest change was returned

=> The client would think that it got all the changes when it potentially didn't

Steps to reproduce

N/A 👆

Expected behavior

Sync token reflects the correct sync step

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in apps/dav/lib/CardDAV/CardDavBackend.php, reading the sync-token handling around lines 856-863 and the limit handling around lines 889-891. Trace how the token relates to the changes returned when a limit is applied; done means the returned sync token represents the correct sync step and does not imply unseen changes were delivered.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.