nextcloud / nextcloud/server

[Bug]: Custom file actions wrong when navigating back to root via breadcrumbs

Open
#49,800 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 30-feedback bug
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

In v30, after loading the root file listing, custom file actions are added correctly via execution of the enabled() function, and they continue to be correct as one drills down into subdirectories, but when returning to the “All files” root view, all files/nodes at the root view have the custom actions according to the folder one just returned from.

E.g. if the root has two directories “foo” and “bar” and the custom file action “doFoo” is added to the “foo” directory and “doBar” is added to the “bar” directory, and one drills down into “bar” and then clicks “All files” in the breadcrumbs, both “foo” and “bar” have the action “doBar”.

If one reloads the view, the custom actions are fixed.

Debugging shows that enabled() is being called only for the “bar” folder but not “foo” when the root view is returned to via breadcrumbs from within the “bar” subtree.

Steps to reproduce

See description.

Expected behavior

Custom file actions are always correct, even if one uses breacrumbs to navigate.

Nextcloud Server version

30

Operating system

RHEL/CentOS

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the v30 root file listing scenario: enter a subdirectory, then return to “All files” through the breadcrumbs and compare custom actions on each root node. Done means each file and directory has the action set determined by its own location, without requiring a page reload.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.