nextcloud / nextcloud/server

Remove password checks for shared folders or make them optional

Open
#49,415 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Version: Nextcloud Hub 8 (29.0.2)

Description: There was a change from previous versions when sharing a folder via link. I tried to share a link for a small group of people with a password. In contrast to earlier versions, the password is now being checked for "quality" (e.g., too short, in list of known passwords).

Although I understand that usually it is a good idea to advocate for strong passwords, I am not so sure this makes sense in the specific use case of shared folders. One use case for such folders is to share files with a group of people like students, people on a conference etc., where the password is not strictly confidential anyway. It rather makes sure that the data cannot be collected by automated tools.

I also see that there are other cases where the shared data may be more sensitive, and stronger passwords would make sense. Perhaps a good solution might be to make the password checks optional (e.g., opt out).

Problems with the current implementation:

  • Setting a password at all is optional for shared folders. A "weak" password provides at least a mild barrier against automated data collection and has a legal function (e.g., sharing teaching material that contains copyright-protected images with a class). If setting "easy" passwords gets more difficult, this encourages people towards not setting any password at all
  • The way this is currently implemented, nextcloud shows a warning notification. If the password is not changed and the user confirms the shared link, the folder by default gets shared with no password at all. This introduces a new potential security issue.

Suggested solutions:

  • remove the password sanity check
  • provide an opt out or opt in setting for the security checks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the current shared-folder link password validation and the warning flow described in the issue. Clarify whether password checks should be removed or made configurable, then define and verify the behavior for weak passwords, confirmation, and links created without passwords.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.