`occ preview:repair --delete` should not create empty preview folders
Open
Nobody has claimed this yet.
1. to develop
30-feedback
bug
feature: previews and thumbnails
performance 🚀
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Creation should be skipped to speed up the deletion.
I was trying to delete my 65k folders and the command ramped up until ~4d run time. Without the get+newFolder it's ~3days.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open core/Command/Preview/Repair.php around lines 216-223 and trace the occ preview:repair --delete path. Confirm the deletion flow skips creating empty preview folders, then verify that the command still removes the targeted folders without the extra creation work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100