nextcloud / nextcloud/server

Support the forwarded header that superceedes X-Forwarded-For

Open
#48,262 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

While the "X-Forwarded-For" header is the de-facto standard, it is not standardised. A standardised alternative is the "forwarded" header.

See: IETF RFC7239

As the haproxy docs put it:

The forwarded header is the IETF RFC7239 header and supersedes the non-standard X-Forwarded-For header and its variants such as X-Forward-For.

The forwarded header is supported my all major reverse proxies, and contains the information needed (client ips, protocol).

It can even include multiple values added on my multiple proxies, which might be useful insight but otherwise needs to be handled or stated in documentation that the last proxy must make sure only one value is present.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified. Start by reading RFC7239 and locating the existing X-Forwarded-For handling; done means the standardized forwarded header is supported, including its proxy-added values, with the handling or documentation for multiple values clarified.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.