Batch deletion : replace "Delete and unshare" (weird) with "Delete and leave share(s)" (more relevant and clear)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
When I select several folders and/or files, and among this selection some items have been shared with me, I think that “unshare” is misleading, because it may look like I'm the one who's going to “unshare”.
I think we need to be consistent with another wording that appears when you want to leave a share (see second screenshot below). It would be nice to replace it with: “Delete and leave share” or (event better IMO) “Delete and leave share(s)”. I think “share(s)” is more appropriate, as there may be one or more shares in the selection you're about to delete.
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the frontend for the batch deletion confirmation text “Delete and unshare” and compare it with the existing leave-share wording shown in the issue. Update the relevant label so multi-selection uses the clearer “Delete and leave share(s)” wording, then verify the batch deletion dialog displays the new text consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100