Workflow engine does not allow for user hidden tags
Open
Nobody has claimed this yet.
0. Needs triage
31-feedback
bug
feature: tags
feature: workflows
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
If an admin creates a tag that is not uservisible and shares that with a non-admin user, this part of the code throws an error.
Why shouldnt it be allowed to have tags that is not visible to the user on a file or folder?
Maybe we can just remove that check?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with apps/workflowengine/lib/Check/FileSystemTags.php at line 87 and trace the check that rejects non-user-visible tags. Reproduce the case where an admin shares a hidden tag with a non-admin user, then verify the workflow accepts the tag without throwing an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100