`user_saml` app disabled on upgrade process (27 > 28) caused all users Favorites to be deleted
Open
Nobody has claimed this yet.
1. to develop
28-feedback
bug
feature: apps management
feature: install and update
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Steps to reproduce
- Upgrade to a major version (27 > 28) from the CLI
- App is disabled as "not compatible" (but it is) by the upgrade script, and re-enabled after also by the script
- In the meanwhile, all users Favorites (at least) where lost because deleted by the Cleanup step.
See also https://github.com/nextcloud/server/issues/7615#issuecomment-386217515
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CLI major-version upgrade flow and its app compatibility handling, then trace the Cleanup step described in the reproduction. Done means a compatible user_saml app is not incorrectly disabled during the upgrade and users' Favorites are preserved; no specific files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100