Add UI option to configure an extra logo variant
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
It has been previously discussed in nextcloud/richdocuments#2832 that, when using a custom logo which is white or black, it can be difficult to see when using Collabora. We have already added a workaround for this in nextcloud/richdocuments#3840 by allowing to set CSS variables using the custom theming app to control the logo background color or visibility, but this is simply a workaround.
Describe the solution you'd like
A proper solution would be to allow the user to set both a light and dark variant of their custom logo to be used when the logo would be otherwise difficult to see (for example, when using a white logo and opening Collabora in bright mode).
Describe alternatives you've considered
The alternatives considered are mentioned above with nextcloud/richdocuments#3840, but it's simply a workaround and doesn't provide a clear way to solve the issue. It would be better to present the option in the theming settings by default.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the theming settings entry point and the workaround discussed in nextcloud/richdocuments#3840, then compare the prior discussion in nextcloud/richdocuments#2832. Done means users can configure both light and dark custom logo variants and the appropriate variant is shown when Collabora's bright or dark mode would make the logo hard to see.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100