[Bug]: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at lib/private/Comments/Manager.php#95
Open
@kesselb is already working on this.
Since Aug 1, 2024.
1. to develop
29-feedback
bug
feature: comments
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
Found in a log file:
url: /apps/recommendations/api/recommendations
message: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at lib/private/Comments/Manager.php#95
version: 29.0.3.5
I'm confused. The IComment object tries to decode the json when calling getMetaData, but normalizeDatabaseData already decoded it?
Steps to reproduce
No idea, found it in the customer log.
Expected behavior
Column does not allow null, but somehow we call json_decode with null.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.